Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

MangaDex Loader #870

Merged
merged 1 commit into from
Jan 19, 2024
Merged

MangaDex Loader #870

merged 1 commit into from
Jan 19, 2024

Conversation

choombaa
Copy link
Contributor

Added MangaDexReader, which loads documents from the MangaDex API.

Description

This loader fetches information from the MangaDex API

Screenshot from 2024-01-16 16-37-57

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Added MangaDexReader, which loads documents from the MangaDex API.
Copy link
Collaborator

@anoopshrma anoopshrma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for the contribution!
Being an anime geek myself, super happy to see this loader 😅

@nerdai
Copy link
Contributor

nerdai commented Jan 19, 2024

merging thanks for contribution @choombaa !

@nerdai nerdai closed this Jan 19, 2024
@nerdai nerdai reopened this Jan 19, 2024
@nerdai nerdai merged commit a486d1f into run-llama:main Jan 19, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants