Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Add timeout arg to github repo reader #873

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Add timeout arg to github repo reader #873

merged 2 commits into from
Jan 19, 2024

Conversation

rwood-97
Copy link
Contributor

Description

This PR adds a timeout arg to the GithubRepositoryReader to allow users to specify a timeout when making requests.
Fixes #846

Type of Change

Please delete options that are not relevant.

  • Bug fix / Smaller change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@rwood-97 rwood-97 marked this pull request as ready for review January 18, 2024 09:32
@anoopshrma
Copy link
Collaborator

Thank you for the contribution!

@nerdai
Copy link
Contributor

nerdai commented Jan 19, 2024

Thanks for the fix @rwood-97 !

@nerdai nerdai merged commit 10850e8 into run-llama:main Jan 19, 2024
3 checks passed
@rwood-97 rwood-97 deleted the github-timeout branch January 22, 2024 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: httpx.ConnectTimeout errors when using GithubRepositoryReader
3 participants