-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Graph-Supported-FalkorDB #16482
base: main
Are you sure you want to change the base?
Conversation
@galshubeli is it possible to add a test or two that actually runs in CICD? Seems like coverage is quite low |
I added tests, but I need to find a way to add an environment variable. How can I do that? |
Seems like the tests you added require connecting to an actual falkordb instance Either
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this to the property graph store? Just realized only the other graph store is updated
For reference, technically the property graph store is what most users would be using -- we can add to another PR though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump the version of the integration? (I can't actually push to the PR branch)
Is there a way to use Docker in this workflow? Mocking the client not test the connection with the graph. |
@galshubeli you can technically spin up docker yea, there's a few unit tests that do this Check out But also, mocking the client is fine, assuming the mocked responses are accurate |
Description
Switch graph:
Feature Introduction: Adds the switch_graph(graph_name: str) method to allow switching between graphs on the same database connection.
Why It's Needed:
Improves efficiency when working with multiple graphs under the same driver.
Removes the need to open a new connection for each graph, reducing connection overhead.
Use Case:
Ideal for applications managing several graphs simultaneously, where quick transitions between graphs are required without disconnecting or re-establishing new connections.
Goal:
Enhance performance and streamline workflows by maintaining a single connection while managing different graphs.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods