Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Graph-Supported-FalkorDB #16482

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

galshubeli
Copy link
Contributor

@galshubeli galshubeli commented Oct 10, 2024

Description

Switch graph:

Feature Introduction: Adds the switch_graph(graph_name: str) method to allow switching between graphs on the same database connection.

Why It's Needed:
Improves efficiency when working with multiple graphs under the same driver.
Removes the need to open a new connection for each graph, reducing connection overhead.

Use Case:
Ideal for applications managing several graphs simultaneously, where quick transitions between graphs are required without disconnecting or re-establishing new connections.

Goal:
Enhance performance and streamline workflows by maintaining a single connection while managing different graphs.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 10, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 10, 2024
@logan-markewich
Copy link
Collaborator

@galshubeli is it possible to add a test or two that actually runs in CICD? Seems like coverage is quite low

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 13, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 13, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 14, 2024
@galshubeli
Copy link
Contributor Author

@galshubeli is it possible to add a test or two that actually runs in CICD? Seems like coverage is quite low

I added tests, but I need to find a way to add an environment variable. How can I do that?

@logan-markewich
Copy link
Collaborator

logan-markewich commented Oct 15, 2024

Seems like the tests you added require connecting to an actual falkordb instance

Either

  • mark them as skip if the instance isn't reachable (you can use os.environ to check for env variables present)
  • mock out the client interactions so that they can run in CICD
  • if falkordb has an "in-instance in-memory mode" we could use that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to the property graph store? Just realized only the other graph store is updated

For reference, technically the property graph store is what most users would be using -- we can add to another PR though

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the version of the integration? (I can't actually push to the PR branch)

@galshubeli
Copy link
Contributor Author

Can you bump the version of the integration? (I can't actually push to the PR branch)

Is there a way to use Docker in this workflow? Mocking the client not test the connection with the graph.

@logan-markewich

@logan-markewich
Copy link
Collaborator

@galshubeli you can technically spin up docker yea, there's a few unit tests that do this

Check out llama-index-integrations/vector-stores/llama-index-vector-stores-redis/tests

But also, mocking the client is fine, assuming the mocked responses are accurate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants