Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playwright browser tool #17706

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

jisonZ
Copy link

@jisonZ jisonZ commented Feb 3, 2025

Description

Add playwright browser agent tool, most code are adapted from the corresponding tool in langchain: https://github.com/langchain-ai/langchain/tree/0c782ee5479f1eadf6cc532d7f27617bd2671fe9/libs/community/langchain_community/tools/playwright.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • Added example for testing functionality
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 3, 2025
from llama_index.core.tools.tool_spec.base import BaseToolSpec


def lazy_import_playwright_browsers():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty function?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 32115c8

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me honestly, nice!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2025
@jisonZ
Copy link
Author

jisonZ commented Feb 4, 2025

@logan-markewich If the fixes look alright can we get the github actions going? It seems to stuck at "waiting for status to be reported", not sure if a maintainer permission is required here

@logan-markewich
Copy link
Collaborator

@jisonZ yea first-time maintainers require manually trigger of the actions. A little annoying, but once this merges, future PRs for you will run automatically :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants