-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playwright browser tool #17706
base: main
Are you sure you want to change the base?
Conversation
from llama_index.core.tools.tool_spec.base import BaseToolSpec | ||
|
||
|
||
def lazy_import_playwright_browsers(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 32115c8
...a-index-integrations/tools/llama-index-tools-playwright/llama_index/tools/playwright/base.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me honestly, nice!
llama-index-integrations/tools/llama-index-tools-playwright/tests/test_tools_playwright.py
Show resolved
Hide resolved
@logan-markewich If the fixes look alright can we get the github actions going? It seems to stuck at "waiting for status to be reported", not sure if a maintainer permission is required here |
@jisonZ yea first-time maintainers require manually trigger of the actions. A little annoying, but once this merges, future PRs for you will run automatically :) |
Description
Add playwright browser agent tool, most code are adapted from the corresponding tool in langchain: https://github.com/langchain-ai/langchain/tree/0c782ee5479f1eadf6cc532d7f27617bd2671fe9/libs/community/langchain_community/tools/playwright.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
make format; make lint
to appease the lint gods