Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BitBucket Cloud: add support for webhook secrets #4275

Conversation

almightyfoon
Copy link
Contributor

@almightyfoon almightyfoon commented Feb 22, 2024

what

Added support for Bitbucket Cloud Webhook secrets. Bitbucket added support in the cloud offering in October of 2023 Announcement

  • Ported the request validation libraries from bitbucket server to bitbucket cloud client.
  • Removed error check and associated test to ensure they aren't being used because they weren't supported

why

There is an open request for this #3909 and I'm also in need of this feature.

tests

I ran make test, the logic is the same as bitbucketserver.

references

@almightyfoon almightyfoon requested review from a team as code owners February 22, 2024 05:27
@almightyfoon almightyfoon requested review from jamengual, lukemassa and nitrocode and removed request for a team February 22, 2024 05:27
@github-actions github-actions bot added go Pull requests that update Go code provider/bitbucket labels Feb 22, 2024
@almightyfoon almightyfoon changed the title adding support for bitbucket cloud webhook secrets feat: adding support for bitbucket cloud webhook secrets Feb 22, 2024
@github-actions github-actions bot added the docs Documentation label Feb 22, 2024
@jamengual jamengual added waiting-on-review Waiting for a review from a maintainer and removed docs Documentation labels Feb 26, 2024
@pavankumar-go
Copy link

kindly get this change merged. we are in very much need for this feature.

@jamengual jamengual added this to the v0.28.0 milestone Mar 26, 2024
@chenrui333 chenrui333 modified the milestones: v0.28.0, v0.29.0 May 22, 2024
@X-Guardian
Copy link
Contributor

@almightyfoon, can you resolve the conflicts on this PR?

@X-Guardian X-Guardian added waiting-on-response Waiting for a response from the user and removed waiting-on-review Waiting for a review from a maintainer labels Nov 5, 2024
@github-actions github-actions bot added the docs Documentation label Nov 5, 2024
Copy link

github-actions bot commented Dec 7, 2024

This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month.

@github-actions github-actions bot added the Stale label Dec 7, 2024
@marwan38
Copy link

Gentle bump, would be nice to have this.

@jamengual jamengual removed the Stale label Dec 10, 2024
@jamengual
Copy link
Contributor

Very little work needs to be done to get this merged, if anyone can pick it up and finish the changes we could get this merged.

@almightyfoon
Copy link
Contributor Author

Sorry for the delay, real life got in the way. Working on clearing the failed tests.

@X-Guardian X-Guardian removed this from the v0.29.0 milestone Dec 17, 2024
@jamengual
Copy link
Contributor

@almightyfoon do you have time to finish this? Thanks.

@X-Guardian
Copy link
Contributor

Hi @almightyfoon, can you take a look at the linting error:

 server/controllers/events/events_controller.go:235:54:
 printf: non-constant format string in call to (*github.com/runatlantis/atlantis/server/controllers/events.VCSEventsController).respond (govet)

@X-Guardian X-Guardian changed the title feat: adding support for bitbucket cloud webhook secrets feat: BitBucket Cloud: add support for webhook secrets Jan 25, 2025
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the linting issue.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2025
@X-Guardian X-Guardian merged commit 05659b8 into runatlantis:main Jan 25, 2025
38 of 39 checks passed
@Almenon
Copy link
Contributor

Almenon commented Jan 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation go Pull requests that update Go code lgtm This PR has been approved by a maintainer provider/bitbucket security waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for bitbucket cloud webhook secrets
9 participants