Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set Env variables when output: hide in multienv #5319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hkobayash
Copy link

what

why

  • I want to suppress Dynamic environment variables added: message.

tests

go test -v ./server/core/runtime -run ^TestMultiEnvStepRunner_Run$
=== RUN   TestMultiEnvStepRunner_Run
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'
    logger.go:146: 2025-02-13T01:49:55.324+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_ONE=value12886480706/001'
    logger.go:146: 2025-02-13T01:49:55.359+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_ONE=value1'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_ONE=value12886480706/001'      {"duration": "35.162916ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='
    logger.go:146: 2025-02-13T01:49:55.364+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=2234019066/001'
    logger.go:146: 2025-02-13T01:49:55.371+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1='' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=2234019066/001'  {"duration": "7.586209ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'
    logger.go:146: 2025-02-13T01:49:55.379+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_NO_VALUE254333198/001'
    logger.go:146: 2025-02-13T01:49:55.395+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_NO_VALUE254333198/001'   {"duration": "15.660917ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true'
    logger.go:146: 2025-02-13T01:49:55.398+0900 DEBUG   starting 'sh -c "echo 'TF_VAR1_MULTILINE=\"foo\\\\nbar\",TF_VAR2_VALUEWITHCOMMA=\"one,two\",TF_VAR3_CONTROL=true'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR1_MULTILINE=foonbar,TF_VAR2_VALUEWITHCOMMA=one,two,TF_VAR3_CONTROL=true3330121634/001'
    logger.go:146: 2025-02-13T01:49:55.404+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR1_MULTILINE=foonbar,TF_VAR2_VALUEWITHCOMMA=one,two,TF_VAR3_CONTROL=true3330121634/001'      {"duration": "6.035833ms"}
=== RUN   TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'
    logger.go:146: 2025-02-13T01:49:55.406+0900 DEBUG   starting 'sh -c "echo 'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'"' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_HIDE=value13894026439/001'
    logger.go:146: 2025-02-13T01:49:55.411+0900 INFO    successfully ran 'sh -c' 'echo 'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1'' in '/var/folders/r6/p00czz410znf64jnxzl9sx7c0000gq/T/TestMultiEnvStepRunner_Runecho_TF_VAR_REPODEFINEDVARIABLE_HIDE=value13894026439/001'    {"duration": "4.636083ms"}
--- PASS: TestMultiEnvStepRunner_Run (0.09s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_ONE=value1' (0.04s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_TWO=value=1=' (0.01s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_NO_VALUE' (0.02s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR1_MULTILINE="foo\\nbar",TF_VAR2_VALUEWITHCOMMA="one,two",TF_VAR3_CONTROL=true' (0.01s)
    --- PASS: TestMultiEnvStepRunner_Run/echo_'TF_VAR_REPODEFINEDVARIABLE_HIDE=value1' (0.01s)
PASS
ok      github.com/runatlantis/atlantis/server/core/runtime     0.372s

references

@hkobayash hkobayash requested review from a team as code owners February 12, 2025 16:56
@hkobayash hkobayash requested review from GenPage, lukemassa and X-Guardian and removed request for a team February 12, 2025 16:56
@dosubot dosubot bot added bug Something isn't working go Pull requests that update Go code labels Feb 12, 2025
Signed-off-by: Hirotake Kobayashi <[email protected]>
@hkobayash hkobayash force-pushed the fix/multienv_step_output branch from 2a8c860 to 6901622 Compare February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atlantis does not set Env variables when output: hide in multienv
1 participant