Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update --emoji-reactions Documentation #5327

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Len4i
Copy link

@Len4i Len4i commented Feb 13, 2025

what

Github allowing only specific emojis to be sent as reaction and thumbsup is not on of them
can be +1 instead according to their list, didn't test it personally

why

Documentation is not accurate. I've spent some time trying to understand why emoji is not working

references

Link to github documentation

Github allowing only specific emojis to be sent as reaction and `thumbsup` is not on of them (can be `+1` instead, but didn't test it)

Signed-off-by: Leonid Podolinskiy <[email protected]>
@Len4i Len4i requested review from a team as code owners February 13, 2025 15:25
@Len4i Len4i requested review from GenPage, lukemassa and nitrocode and removed request for a team February 13, 2025 15:25
@dosubot dosubot bot added the docs Documentation label Feb 13, 2025
@Len4i Len4i changed the title Update --emoji-reactions documentation docs: --emoji-reactions github allowed list Feb 13, 2025
@X-Guardian
Copy link
Contributor

Can you also add a link to the Gitlab emoji list to your change: https://gitlab.com/gitlab-org/gitlab/-/blob/master/fixtures/emojis/digests.json

Signed-off-by: Leonid Podolinskiy <[email protected]>
@Len4i
Copy link
Author

Len4i commented Feb 13, 2025

Can you also add a link to the Gitlab emoji list to your change: https://gitlab.com/gitlab-org/gitlab/-/blob/master/fixtures/emojis/digests.json

Sure! I was trying to find this list in their documentation by myself but had no luck.
Added link, thank you

@X-Guardian X-Guardian changed the title docs: --emoji-reactions github allowed list docs: Update --emoji-reactions Documentation Feb 14, 2025
Signed-off-by: Leonid Podolinskiy <[email protected]>
Signed-off-by: Leonid Podolinskiy <[email protected]>
@Len4i Len4i requested a review from X-Guardian February 14, 2025 17:50
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2025
@X-Guardian X-Guardian enabled auto-merge (squash) February 14, 2025 18:20
@Len4i
Copy link
Author

Len4i commented Feb 15, 2025

@X-Guardian looks like muffet check is failing on the Join us on Slack button. Probably something changed in the cncf slack. It's not urgent for me to merge this PR, just wanted to bring awareness, probably it will affect other PRs as well

@X-Guardian
Copy link
Contributor

The https://communityinviter.com/ website that we link to in the docs is down, and has been for at least 24 hours. Nothing to do with your changes. I'll see if I can get the 'Website Link Check' removed from the list of required checks, as it makes no sense to block PRs being merged in this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation lgtm This PR has been approved by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thumbsup and thumbsdown are no longer valid emoji reactions in GitHub
2 participants