-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update --emoji-reactions Documentation #5327
base: main
Are you sure you want to change the base?
Conversation
Github allowing only specific emojis to be sent as reaction and `thumbsup` is not on of them (can be `+1` instead, but didn't test it) Signed-off-by: Leonid Podolinskiy <[email protected]>
Can you also add a link to the Gitlab emoji list to your change: https://gitlab.com/gitlab-org/gitlab/-/blob/master/fixtures/emojis/digests.json |
Signed-off-by: Leonid Podolinskiy <[email protected]>
Sure! I was trying to find this list in their documentation by myself but had no luck. |
Co-authored-by: Simon Heather <[email protected]> Signed-off-by: Leonid Podolinskiy <[email protected]>
Signed-off-by: Leonid Podolinskiy <[email protected]>
Signed-off-by: Leonid Podolinskiy <[email protected]>
@X-Guardian looks like |
The https://communityinviter.com/ website that we link to in the docs is down, and has been for at least 24 hours. Nothing to do with your changes. I'll see if I can get the 'Website Link Check' removed from the list of required checks, as it makes no sense to block PRs being merged in this situation. |
what
Github allowing only specific emojis to be sent as reaction and
thumbsup
is not on of themcan be
+1
instead according to their list, didn't test it personallywhy
Documentation is not accurate. I've spent some time trying to understand why emoji is not working
references
Link to github documentation