Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialise metadata within Player #377

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Jameskmonger
Copy link
Collaborator

Fixes an issue introduced in #376

Issue manifested as follows (reported by Raph on discord)

[2] [2022-09-13T01:55:22.550Z] ERROR (16960 on desktop-raph): Cannot read property 'configs' of undefined
[2]     TypeError: Cannot read property 'configs' of undefined
[2]         at OutboundPacketHandler.updateClientConfig (C:\Users\raphp\source\repos\runejs-server\src\engine\net\outbound-packet-handler.ts:282:22)
[2]         at Player.updateQuestTab (C:\Users\raphp\source\repos\runejs-server\src\engine\world\actor\player\player.ts:1166:30)
[2]         at Player.init (C:\Users\raphp\source\repos\runejs-server\src\engine\world\actor\player\player.ts:241:14)
[2]         at GatewayServer.createPlayer (C:\Users\raphp\source\repos\runejs-server\src\server\gateway\gateway-server.ts:181:22)
[2]         at GatewayServer.parseLoginServerResponse (C:\Users\raphp\source\repos\runejs-server\src\server\gateway\gateway-server.ts:130:36)
[2]         at Socket.<anonymous> (C:\Users\raphp\source\repos\runejs-server\src\server\gateway\gateway-server.ts:66:22)
[2]         at Socket.emit (events.js:400:28)
[2]         at addChunk (internal/streams/readable.js:293:12)
[2]         at readableAddChunk (internal/streams/readable.js:267:9)
[2]         at Socket.Readable.push (internal/streams/readable.js:206:10)
[2] [2022-09-13T01:55:22.552Z] INFO (16960 on desktop-raph): Connection destroyed.
[2] [2022-09-13T01:55:22.553Z] INFO (16960 on desktop-raph): raph has logged out.

@SchauweM
Copy link
Collaborator

My fault for not checking a clean install.

@SchauweM SchauweM merged commit fb623b9 into runejs:develop Sep 13, 2022
@Jameskmonger Jameskmonger deleted the fix-undefined-metadata branch September 13, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants