Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular deps in project #447

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Fix circular deps in project #447

merged 1 commit into from
Feb 1, 2025

Conversation

DrJacobHolden
Copy link

Fixes ALL circular deps by:

  1. Removing index files
  2. Removing unused imports
  3. Ensuring all type imports use import type
  4. Replace almost all instanceof Player and instanceof Npc checks with isPlayer and isNpc respectively (using the type property rather than class instance comparison so we don't need to circularly reference)

I have lost at least 2 years off my life.

@DrJacobHolden DrJacobHolden mentioned this pull request Feb 1, 2025
Closed
@Katilith Katilith merged commit 4926deb into runejs:develop Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katilith Katilith Katilith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrJacobHolden @Katilith @BorigTheDwarf