Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Better Custom Cursor #6585

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added Better Custom Cursor #6585

wants to merge 6 commits into from

Conversation

archiru
Copy link
Contributor

@archiru archiru commented Sep 13, 2024

This plugin allows users to specify where they want their cursor to point, for images like crosshairs ect.

@runelite-github-app
Copy link

runelite-github-app bot commented Sep 13, 2024

@cdfisher
Copy link
Contributor

cdfisher commented Sep 13, 2024

Before a reviewer even really looks through this, can you clean up all the example plugin stuff from the repo? You're basically bundling the whole example plugin along with what you've written.

Also, is there a reason your plugin's license headers are dated 2018 and seem to only name someone who appears to mostly write WoW add-ons?

Editing to add I failed to check core on that one.

Removed example plugin
@archiru
Copy link
Contributor Author

archiru commented Sep 13, 2024

Thank you, I have now removed the example plugin from the repo, I mistakenly merged.

@YvesW
Copy link
Member

YvesW commented Sep 14, 2024

What does this plugin do that the core plugin, or other cursor plugins on the hub don't already do?
Also, could you come up with a more descriptive name? (I know this can be difficult)

@archiru
Copy link
Contributor Author

archiru commented Sep 14, 2024

This plugin allows the user to change where they want the cursor to click. By default, the custom cursor plugin assumes that cursor starts at 0,0, which is not the case for many custom images, such as crosshairs or arrows.

I will change the name of the plugin, Thank you

@LlemonDuck
Copy link
Contributor

Your build is failing because you are using enabledByDefault = false. You can check the results under the details of the RuneLite Plugin Hub Checks check suite.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants