Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pvp-performance tracker to v1.5.10 #6929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pvp-performance tracker to v1.5.10 #6929

wants to merge 1 commit into from
+1 −1

Conversation

Matsyir
Copy link
Contributor

@Matsyir Matsyir commented Nov 4, 2024

Thanks to @Macweese for these updates

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 4, 2024 •
edited
Loading

pvp-performance-tracker: f8304d22dcf1236e3a255405c4361fc62d382306...c4e1b99159a5a3809a9ce57adabb705cdebc958a

@tylerwgrass
Copy link
Member

The build failed as one of the APIs was recently deprecated.

You'll need to make the update below here and here

- itemStats = PLUGIN.getItemManager().getItemStats(itemId, false);
+ itemStats = PLUGIN.getItemManager().getItemStats(itemId);

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 4, 2024
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 4, 2024
@Matsyir
Copy link
Contributor Author

Matsyir commented Nov 5, 2024

Yay build works now, many thanks for the PR Tyler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matsyir @tylerwgrass