Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loot-filters: cherrypick fix for memory leak #7378

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Update loot-filters: cherrypick fix for memory leak #7378

merged 2 commits into from
Feb 9, 2025

Conversation

riktenx
Copy link
Contributor

@riktenx riktenx commented Feb 9, 2025

Fixes memory leak due to ground item entries / lootbeams staying around forever even as items fall out of scene.

See context in riktenx/loot-filters#40.

@runelite-github-app
Copy link

runelite-github-app bot commented Feb 9, 2025 •
edited
Loading

loot-filters: 688d8d9c44c34f6ac75bb513a40c353f74f8d6af...316fe0dbec1793b14d97bf6708f75e51cd1548f1

@riktenx riktenx changed the title Update loot-filters Update loot-filters: cherrypick fix for memory leak Feb 9, 2025
@riktenx
Copy link
Contributor Author

riktenx commented Feb 9, 2025 •
edited
Loading

Closing this - going to retool the way we handle item despawns per discussion in #development in discord.

I'm cooked rn you can literally just update commits. Reopened it.

@riktenx riktenx closed this Feb 9, 2025
@riktenx riktenx reopened this Feb 9, 2025
tylerwgrass
tylerwgrass approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@tylerwgrass tylerwgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client provides a developerMode bool you could use for your debug overlay

https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/banktags/BankTagsPlugin.java#L152

@iProdigy iProdigy merged commit f871f68 into runelite:master Feb 9, 2025
5 checks passed
@riktenx riktenx mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iProdigy iProdigy iProdigy approved these changes

@tylerwgrass tylerwgrass tylerwgrass approved these changes

Assignees
No one assigned
Labels
plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riktenx @iProdigy @tylerwgrass