Concurrent kore-rpc strikes back
#3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or codes of the successive errors
…add a module at the same time
…f name-as-id is true
…when name-as-id is true
goodlyrottenapple
changed the title
kore-rpc-booster strikes backkore-rpc strikes back
|
Could you also update the docs according to these changes, please? |
|
I opened a PR for the necessary changes in I also added a few integration tests, and one of them is failing: if you add a module, then add the same module with Running the tests: ensure the right K version is on $ make test-integration TEST_ARGS='-n0 -k TestAddModule' |
… with a name failed. also fixed logic of adding the sanem named module with name-as-id true
jberthold
approved these changes
Jan 18, 2024
Comment on lines
31
to
32
| Expected: | ||
| * Module successfully added even though it has been added already, because the content is exactly the same. |
There was a problem hiding this comment.
Probably the module would be added twice then?
How is add-module/add-again executed? The test script does not mention it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revert of the revert of #3704. Needs to be merged in sync with runtimeverification/hs-backend-booster#427 and also a change to
pykto handle the new modules IDs.