Add secp256k1 to llvm-libs #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-89
to
-92
| kup publish k-framework-binary .#k.openssl --keep-days 180 | ||
| kup publish k-framework-binary .#k.procps --keep-days 180 | ||
| kup publish k-framework-binary .#k.openssl.procps --keep-days 180 | ||
| kup publish k-framework-binary .#k.procps.openssl --keep-days 180 |
There was a problem hiding this comment.
I don't think people really install these separately, so we only really need to cache the deps needed for blockchain plugin. perhaps we should even add an alias, something like k.blockchain-plugin-deps?
There was a problem hiding this comment.
Yeah, let's do that in a separate PR. It also avoids having to update instructions in lots of different places if we change the list of dependency libraries (as is happening here).
Baltoli
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also ensures that the package
k.procps.opensslandk.openssl.procpsare exactly the same by sorting the list of llvm-lib paths