fix: fix the truncate error about html

ruofee · Sep 12, 2023 · abdebf7 · abdebf7
1 parent 279fcce
commit abdebf7
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/components/JsEllipsis.vue b/packages/components/JsEllipsis.vue
@@ -180,6 +180,10 @@ export default class JsEllipsis extends Vue {
   private truncateHTML(container: HTMLElement, textContainer: HTMLElement, max: number) {
     // only enter this function when container overflow.
     const children = textContainer.childNodes;
+    if (children.length === 0) {
+      // remove parent node
+      return false;
+    }
     if (children.length === 1) {
       const node = children[0] as HTMLElement;
       if (node.nodeType === Node.TEXT_NODE) {
@@ -240,7 +244,11 @@ export default class JsEllipsis extends Vue {
       );
       if (textContainer.childNodes[i]) {
         // truncate the critical node
-        this.truncateHTML(container, textContainer.childNodes[i] as HTMLElement, max);
+        const truncateResult = this.truncateHTML(container, textContainer.childNodes[i] as HTMLElement, max);
+        // if truncateResult be false, it means that node should be removed
+        if (truncateResult === false) {
+          textContainer.removeChild(textContainer.childNodes[i]);
+        }
       }
     }
   }