Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 4.0.0 release #195

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Prepare 4.0.0 release #195

merged 1 commit into from
Mar 25, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Mar 25, 2024

Since html5ever appears in the public API, this needs a semver-incompatible version bump.

Since html5ever appears in the public API, this needs a
semver-incompatible version bump.
@notriddle
Copy link
Member

Since html5ever appears in the public API

It’s not supposed to. Which function does that?

@djc
Copy link
Contributor Author

djc commented Mar 25, 2024

Ah, sorry -- I misread, was looking at the SanitizationTokenizer's TokenSink impl but that is a private type.

So this can just be 3.4.0 I guess?

@notriddle
Copy link
Member

Preferably, yes. We want people to immediately update to the newest ammonia as soon as we release it, so we need to have a more stable API than html5ever has.

@djc
Copy link
Contributor Author

djc commented Mar 25, 2024

Don't get me wrong, I'm a fan! I've just seen that many maintainers aren't quite so careful about hiding private dependencies.

But, what about the notice in the changelog that says "breaking change" (change lifetimes on UrlRelative)? That's from 32e12a0 (which doesn't seem to carry an affiliation with any PR).

@notriddle
Copy link
Member

You're right. I had forgotten about that.

It's going to be 4.0 after all, then.

@notriddle notriddle merged commit 1111938 into rust-ammonia:master Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants