BIP324 HKDF implementation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dropping the sha2 and hkdf deps in favor of internal implemenation, but this has a long way to go. The packet tests cover the *exact* path for now though, so actually gives good coverage.
nyonson
changed the title
|
Boom! Merged! Nice job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the
sha2andhkdfdependencies in favor of an internal implementation for HKDF based on RFC5869 andbitcoin_hashes. This is limited to BIP324 requirements, so hardcoded with SHA256. The interface is also not as flexible as RFC5869 allows.