Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network flag to proxy and refactor back to one loop #73

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Add network flag to proxy and refactor back to one loop #73

merged 2 commits into from
Oct 3, 2024

Conversation

nyonson
Copy link
Collaborator

@nyonson nyonson commented Oct 3, 2024 •
edited
Loading

  • Allow the proxy to run on bitcoin networks other than mainnet.
  • Now that both the V2 and V1 async read options are cancellation safe (by making them little state machines) we can go back to the proxy be a simple select loop.

Additional Tests

  • Ran with nakamoto locally.

@nyonson nyonson requested a review from rustaceanrob October 3, 2024 19:57
@rustaceanrob
Copy link
Collaborator

ACK 6b7c080

@rustaceanrob rustaceanrob merged commit 1d97c9b into rust-bitcoin:main Oct 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustaceanrob rustaceanrob Awaiting requested review from rustaceanrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyonson @rustaceanrob