Switch to mutable refs for async io #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyonson
changed the title
|
While we are at it can we switch to something more like |
|
Just needs rebase and looks good |
nyonson
force-pushed
the
switch-to-mutable-io-refs
branch
from
1439076 to
c0457ed
Compare
nyonson
force-pushed
the
switch-to-mutable-io-refs
branch
from
c0457ed to
98fe548
Compare
|
ACK 98fe548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutable refs appear to fit a little better in the async runtime ecosystem. This interface is a little more flexible since it can always be wrapped by another type which owns the I/O instances and just passes down references.
Since breaking things anyway in the interface, added more descriptive function names.