Support jsonc format #457
Open
Support jsonc format #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: T.C. <[email protected]>
Signed-off-by: T.C. <[email protected]>
matthiasbeyer
requested changes
Sep 20, 2023
| @@ -52,7 +52,7 @@ fn test_file() { | |||
| assert_eq!(s.place.telephone, None); | |||
| assert_eq!(s.elements.len(), 10); | |||
| assert_eq!(s.elements[3], "4".to_string()); | |||
| if cfg!(feature = "preserve_order") { | |||
| if cfg!(feature = "TODO: preserve_order") { | |||
There was a problem hiding this comment.
well, that's because jsonc-parser doesn't support preserve_order. need time to contribute that
Comment on lines
+91
to
+95
| #[cfg(all(feature = "jsonc", feature = "json"))] | ||
| formats.insert(FileFormat::Jsonc, vec!["jsonc"]); | ||
|
|
||
| #[cfg(all(feature = "jsonc", not(feature = "json")))] | ||
| formats.insert(FileFormat::Jsonc, vec!["jsonc", "json"]); |
There was a problem hiding this comment.
Do I understand correctly that the jsonc parser also parses json even if that feature is disabled?
I think that's counter-intuitive and we should only parse jsonc with the jsonc parser.
There was a problem hiding this comment.
well, there are 2 reasons i added that.
- the file extension for jsonc is actually
.json, not.jsonc, so the real question is that when i enable the featurejsoncit's about the format or the file extension? - for the common usage, people would choose only one of them, not both. and I believe the jsonc format is more common for config files than the json format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a new commit, see #452