Switch syntect regex engine over to onig and add newer JS syntax file #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the engine ~halves the time it takes to render readmes. Timings from rendering all readmes in the database dump from a couple years ago:
It's also required to support the
JavaScript (Babel)
syntax file. This syntax doesn't run into the issue mentioned in #1942, but as I mention there I don't think this is going to be the only trigger so I want to see if there's something else easy we could do to avoid it completely.(Draft because I'm still rebuilding my local server to actually check that the JS syntax looks good when rendered).