Classify FIXMEs - 8 #4236
Classify FIXMEs - 8 #4236
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
lvllvl
force-pushed
the
4117-part-8
branch
3 times, most recently
from
8d8d99c to
b80a8e5
Compare
libc-test/build.rs
Outdated
| @@ -4480,9 +4480,9 @@ fn test_linux(target: &str) { | |||
| }); | |||
|
|
|||
| cfg.skip_roundtrip(move |s| match s { | |||
| // FIXME: | |||
| // FIXME(ctest): | |||
There was a problem hiding this comment.
Same as the other PR, a couple instances of FIXME(ctest) that should be something else. Rest looks good!
tgross35
added
the
stable-nominated
lvllvl
force-pushed
the
4117-part-8
branch
4 times, most recently
from
90e8636 to
409c3ee
Compare
|
@tgross35 hi, this PR is ready for another review. I think everything should be addressed but let me know if there's anything else I should change. Thanks! |
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI