feat: Wasm Linux support wasm32-wali
#4244
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
…libtest functionality
| // * Architecture-specific features | ||
| // * Dynamic linking (until Wasm gains support) | ||
| // Currently only supports the 'musl' environment | ||
| fn test_wasm32_linux(target: &str) { |
There was a problem hiding this comment.
Is most of this copied from test_linux? If so, it would just make more sense to configure wali using that same function instead of duplicating.
There was a problem hiding this comment.
A lot of it is configured using test_linux, I can use the same function. Although if it's currently only Tier-3, we could maybe hold-off on libc-test support until a later point in time. I feel like the latter makes more sense to me at the moment
| #![feature(c_variadic)] | ||
| #![feature(concat_idents)] |
There was a problem hiding this comment.
This is just for experimentation, correct? Will need to be removed before merge.
There was a problem hiding this comment.
This will not be necessary if we remove the syscall shims.
There was a problem hiding this comment.
Same question as in #3778, why is there a b64 module when the arch is wasm32?
There was a problem hiding this comment.
As mentioned in #3778, please drop the syscall shims
There was a problem hiding this comment.
The syscall shims are rather integral to portability of many applications. What is the best direction forward to get that into the ecosystem?
Description
Retargetting support to
main(from #3778) forwasm32-waliaccording to MCP rust-lang/compiler-team#797Sources
WALI documentation: https://github.com/arjunr2/WALI
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI