-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks against musl libm #314
Open
tgross35
wants to merge
3
commits into
rust-lang:tgross35/test-refactoring
Choose a base branch
from
tgross35:musl-benchmarks
base: tgross35/test-refactoring
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add benchmarks against musl libm #314
tgross35
wants to merge
3
commits into
rust-lang:tgross35/test-refactoring
from
tgross35:musl-benchmarks
+136
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
musl-benchmarks
branch
from
October 21, 2024 23:38
48ae32e
to
eb7be4d
Compare
tgross35
force-pushed
the
tgross35/test-refactoring
branch
2 times, most recently
from
October 22, 2024 00:06
09d82a7
to
2722bde
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
3 times, most recently
from
October 22, 2024 00:18
6ee7a75
to
b9198d4
Compare
tgross35
force-pushed
the
tgross35/test-refactoring
branch
3 times, most recently
from
October 22, 2024 01:02
6bf4102
to
f778935
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
8 times, most recently
from
October 22, 2024 01:57
087c0b8
to
eff53ce
Compare
tgross35
force-pushed
the
tgross35/test-refactoring
branch
from
October 22, 2024 02:29
f778935
to
044142f
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
3 times, most recently
from
October 22, 2024 02:35
f13d1c2
to
e542cd9
Compare
This PR should be ready. Also depends on #300 so it can't merge directly. |
Finished running on my machine, it looks like our implementations are within 0.5x ~ 2.0x of musl which is pretty good. Full resultsRyzen 9 5900X
|
tgross35
force-pushed
the
tgross35/test-refactoring
branch
from
October 22, 2024 16:36
044142f
to
93a4bd9
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
from
October 22, 2024 16:37
e542cd9
to
0a9c008
Compare
tgross35
force-pushed
the
tgross35/test-refactoring
branch
2 times, most recently
from
October 26, 2024 04:05
12bf64a
to
8ef0575
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
from
October 26, 2024 05:19
0a9c008
to
72ec3b4
Compare
quaternic
reviewed
Oct 27, 2024
tgross35
force-pushed
the
tgross35/test-refactoring
branch
from
October 27, 2024 02:00
8ef0575
to
c3862a3
Compare
tgross35
force-pushed
the
musl-benchmarks
branch
2 times, most recently
from
October 27, 2024 02:07
bcb5fbf
to
bbd31c9
Compare
quaternic
reviewed
Oct 27, 2024
Add a benchmark for each function that checks against `musl_math_sys`.
This has been superseded by the benchmarks in `libm-test`.
tgross35
force-pushed
the
musl-benchmarks
branch
from
October 27, 2024 05:16
086abee
to
629243e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current benchmarks only test a single number for a fixed amount of iterations, and only test the functions in our crate. Add benchmark comparisons between our crate and the build musl libraries so we have a better basis.