Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5206
This is a second part of the fix (first was #5997).
This PR adds a new method to the
CompletionContext
:no_completion_required
. If this method returnstrue
, it essentially means that user is unlikely to expect any hints from the IDE at this cursor position.Currently, checks for the following cases were added:
fn
: user creates a new function, names of existing functions won't be helpful. Exception for this case isimpl Foo for Bar
-- we must suggest trait function names.for _ i<|>
: it's obviously going to bein
keyword, any hints here will be confusing.More checks may be added there later, but currently I've only figured two cases.