Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove itertools #3086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove itertools #3086

wants to merge 1 commit into from

Conversation

blukai
Copy link

@blukai blukai commented Jan 10, 2025

std can do what peeking_take_while does! nothing else is used from itertools.

std can do what `peeking_take_while` does! nothing else is used from itertools.
@oberrich
Copy link

itertools will be needed in #3088, any particular reason we want to get rid of it?

@blukai
Copy link
Author

blukai commented Jan 30, 2025

I glanced over the changes in the referenced pr and have not spotted itertools there.

the whole reason for this change is me being curious why there's itertools in my dependency tree (cargo tree) (among other micro-dependencies); after quick inspection I discovered absolutely no evidence of its usefulness.

@oberrich
Copy link

oberrich commented Jan 30, 2025

Apologies for the confusion, I'm referring to the alias branch as per #3088 (comment) and see here for the relevant function.
It's a lot nicer to have this in one functional chain instead of having to do it the boring way.

Shouldn't be too much headache to merge my PR if you remove it on a second thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants