-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite non_copy_const
#13207
base: master
Are you sure you want to change the base?
Rewrite non_copy_const
#13207
Conversation
43b7ea2
to
f7ac39d
Compare
f7ac39d
to
ae1ee75
Compare
I think this is ready now. I'll just need to add an overview for the code and remove the old tests (the new ones should cover all those cases now). #13200 still needs to be looked at as well. |
1a30863
to
bf4c37c
Compare
☔ The latest upstream changes (presumably #11441) made this pull request unmergeable. Please resolve the merge conflicts. |
`borrow_interior_mutable_const` messages to be less assertive. Update documentation for both lints.
bf4c37c
to
b2ec6f8
Compare
@llogiq Any chance you'll finish the review before Thursday? That's the last sync to get this in for 1.83. |
☔ The latest upstream changes (presumably #13278) made this pull request unmergeable. Please resolve the merge conflicts. |
The most pressing of the issues are now fixed in #13290. |
Sorry it took so long to review, but this seems good to merge. Let's hope we're in time. @bors r+ |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
fixes #12979
fixes #12951
fixes #13233
Tests still need to be finished and the docs still need to be updated, but this should otherwise ready.
changelog: Lint
declare_interior_mutable_const
andborrow_interior_mutable_const
more precisely