Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lintcheck: force warn all lints #13210

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Alexendoo
Copy link
Member

It occurred to me that like --filter we could use --force-warn for normal operations, we especially want to see lints that crates decided were too annoying or were false positives

Also excludes clippy::cargo from the default set as nobody is really writing those and it slows things down

r? @xFrednet

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 3, 2024
@xFrednet
Copy link
Member

xFrednet commented Aug 6, 2024

Looks good to me, thanks!


Time to come up with another poem, let's see

Roses are red,
Violets are blue,
Let's --force-warn
to see allowed lints too

If only there was an easier way to merge PRs 🤔 :P

@bors
Copy link
Collaborator

bors commented Aug 6, 2024

📌 Commit d18ce7c has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 6, 2024

⌛ Testing commit d18ce7c with merge a411267...

@bors
Copy link
Collaborator

bors commented Aug 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing a411267 to master...

@bors bors merged commit a411267 into rust-lang:master Aug 6, 2024
8 checks passed
@Alexendoo Alexendoo deleted the lintcheck-force-warn branch August 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants