Respect allow inconsistent_struct_constructor on the struct definition

[rzvxa]

Closes #13203

Now we check if the target type is marked with #[allow(clippy:inconsistent_struct_constructor)] before lining.
As a side-effect of this change, The rule in the subject no longer runs on non-local AdtDefs. However, as suggested by @Jarcho it shouldn't be a big deal since most of the time we didn't have access to this information anyway.

You can't get lint attributes from other crates. I would probably just restrict the lint to only work with types from the current crate while you're at it. Upstream crates don't have a definition order from the point of view of the current crate (with the exception of #[repr(C)] structs).

changelog: Respect allow inconsistent_struct_constructor on the struct definition.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rzvxa]

@Alexendoo It would be awesome if we get reviews on this somewhere before the next release; We'd love to see this in the upcoming version of Clippy, It allows us to skip writing a bunch of temporary constructors.

On the other hand; If it is rejected, knowing it will help us start developing alternative approaches through builder methods.

[Jarcho]

This won't land until at least 1.82. We follow the same nightly->beta->stable release process that rust does. Next beta cutoff is at the beginning of September, so plenty of time.

[rzvxa]

This won't land until at least 1.82. We follow the same nightly->beta->stable release process that rust does. Next beta cutoff is at the beginning of September, so plenty of time.

Oh, I thought September was the stable cutoff that's why I was trying to push the review to an earlier date. Thanks for informing me mate, You've been really helpful to me in the past few days. I appreciate it.

[Alexendoo]

This can use fulfill_or_allow just before the span_lint_and_sugg so that #[expect] also works

[rzvxa]

Sorry, I've missed this review in my notifications, Pushed a patch addressing this change request.
@rustbot review

[Alexendoo]

Thank you!

@bors r+

[bors]

📌 Commit d85cf0b has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit d85cf0b with merge 1c81105...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 1c81105 to master...