Check exit status of subcommands spawned by rustc_tools_util #13217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git commands
git rev-parse --short HEAD
andgit log -1 --date=short --pretty=format:%cd
that clippy runs from its build script might fail with "fatal: not a git repository (or any of the parent directories): .git" if clippy is being built from a source tarball rather than a git repository. That message is written by git to stderr, and nothing is written to stdout.For
clippy-driver --version
this PR wouldn't make a difference because it treats empty stdout and failed spawns (git
is not installed) identically:rust-clippy/rustc_tools_util/src/lib.rs
Lines 35 to 42 in 7ac242c
But other users of
rustc_tools_util
should be able to expect that the distinction between Some and None is meaningful. They shouldn't need extra code to handle None vs Some-and-empty vs Some-and-nonempty.changelog: none