Move internal lints to their own crate #13223
Conversation
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
internal_lint
branch
2 times, most recently
from
6274ff4
to
6320f1a
Compare
|
☔ The latest upstream changes (presumably #13225) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
added
the
S-blocked
|
Marking this as blocked on #13221 |
Jarcho
removed
the
S-blocked
|
r? rust-lang/clippy This was simplified a bit by #13221. |
tests/dogfood.rs
Outdated
There was a problem hiding this comment.
Could do with adding the new crate to the list of dogfooded crates
Jarcho
force-pushed
the
internal_lint
branch
3 times, most recently
from
8314085
to
34be10e
Compare
| ]; | ||
|
|
||
| pub fn register_lints(store: &mut LintStore) { | ||
| store.register_lints(LINTS); |
There was a problem hiding this comment.
This no longer registers the clippy::internal group. I assume that's intentional since it's not needed anymore for #![deny(clippy::internal)] in tests and -Dclippy::internal as all internal lints are now warn by default?
There was a problem hiding this comment.
The internal category is now completely gone. It was only really needed to mark some generated code with #[cfg(feature = "internal")].
| @@ -194,7 +192,6 @@ pub fn rename(old_name: &str, new_name: &str, uplift: bool) { | |||
| let name = f.path().file_name(); | |||
| let ext = f.path().extension(); | |||
| (ext == Some(OsStr::new("rs")) || ext == Some(OsStr::new("fixed"))) | |||
| && name != Some(OsStr::new("rename.rs")) | |||
There was a problem hiding this comment.
This changed in a previous PR. Renamed lints were moved into the same file as deprecated lints.
There was a problem hiding this comment.
I assume with previous PR you mean #13180. That removed renamed_lints.rs, right, but the separate ui test rename.rs still exists? Maybe I don't understand what this exclusion is for in the first place. I'd assumed it's because the ui test and the list of deprecations/renames require special handling and are regenerated, and they still are, so I would think that both conditions here are still needed?
Sorry for all the questions, I'd like to properly understand what's going on here 😅
clippy_internal_lints/Cargo.toml
Outdated
| itertools = "0.12" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| serde_json = { version = "1.0" } | ||
| tempfile = { version = "3.3.0" } |
| msrv_attr_impl::MISSING_MSRV_ATTR_IMPL, | ||
| outer_expn_data_pass::OUTER_EXPN_EXPN_DATA, | ||
| produce_ice::PRODUCE_ICE, | ||
| unnecessary_def_path::UNNECESSARY_DEF_PATH, |
There was a problem hiding this comment.
This is missing UNSORTED_CLIPPY_UTILS_PATHS
|
☔ The latest upstream changes (presumably #13343) made this pull request unmergeable. Please resolve the merge conflicts. |
This makes it so switching the internal feature on/off no longer rebuilds
clippy_lints.r? @flip1995
changelog: none