-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use is_diagnostic_item
for checking a def_id in unnecessary_min_or_max
.
#13235
Conversation
f8cab30
to
0c535f8
Compare
0c535f8
to
c2ed04b
Compare
match_def_path
is_diagnostic_item
for checking a def_id in unnecessary_min_or_max
.
Looks good to me. Thank you for this improvement. @bors r+ |
Use `is_diagnostic_item` for checking a def_id in `unnecessary_min_or_max`. close #13191 This PR fixes the false positives in `unnecessary_min_or_max `. We should use `is_diagnostic_item` for checking def_ids in this lint. ---- changelog: fix false positive in `unnecessary_min_or_max `
💔 Test failed - checks-action_test |
@bors retry |
Use `is_diagnostic_item` for checking a def_id in `unnecessary_min_or_max`. close #13191 This PR fixes the false positives in `unnecessary_min_or_max `. We should use `is_diagnostic_item` for checking def_ids in this lint. ---- changelog: fix false positive in `unnecessary_min_or_max `
💔 Test failed - checks-action_test |
@llogiq https://github.com/rust-lang/rust-clippy/actions/runs/10568283502/job/29278932177 |
@bors retry |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
close #13191
This PR fixes the false positives in
unnecessary_min_or_max
.We should use
is_diagnostic_item
for checking def_ids in this lint.changelog: fix false positive in
unnecessary_min_or_max
.