Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing message in double_must_use lint #13241

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

alex-semenyuk
Copy link
Member

Close #13003
As mentioned at #13003 it isn't quite clear what it means "an empty #[must_use] attribute" so clarify it

changelog: [none]

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 8, 2024
@alex-semenyuk
Copy link
Member Author

r? rust-lang/clippy

@rustbot rustbot assigned xFrednet and unassigned Centri3 Aug 18, 2024
@xFrednet
Copy link
Member

Looks good to me! Thank you for the updated message!


Roses are red,
Violets are blue,
This poem is empty,
like the #[must_use]

@bors
Copy link
Collaborator

bors commented Aug 20, 2024

📌 Commit 9948b42 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 20, 2024

⌛ Testing commit 9948b42 with merge 70650de...

@bors
Copy link
Collaborator

bors commented Aug 20, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 70650de to master...

@bors bors merged commit 70650de into rust-lang:master Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing message (empty attribute) in double_must_use
5 participants