Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cc dependency #130406

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Bump cc dependency #130406

merged 1 commit into from
Sep 19, 2024

Conversation

arttet
Copy link
Contributor

@arttet arttet commented Sep 15, 2024

  • The issue was fixed in the PR
  • The build artifacts of arm64e-apple-darwin can be found here

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 15, 2024
@rust-log-analyzer

This comment has been minimized.

@arttet
Copy link
Contributor Author

arttet commented Sep 18, 2024

r? onur-ozkan bjorn3

@onur-ozkan
Copy link
Member

Last time we had a lot of trouble on bumping cc. Let's see what happens this time :)

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 18, 2024

📌 Commit edaabcb has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2024
Bump cc dependency

* The [issue](rust-lang#130231) was fixed in the [PR](rust-lang/cc-rs#1207)
* The build artifacts of arm64e-apple-darwin can be found [here](https://github.com/arttet/rust-compiler-builder/actions/runs/10902308425)
@bors
Copy link
Contributor

bors commented Sep 18, 2024

⌛ Testing commit edaabcb with merge 65c230f...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 18, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2024
@arttet
Copy link
Contributor Author

arttet commented Sep 18, 2024

Hey @onur-ozkan

Could you please assist me to find a reason of this fault? It seems CI hallucinates.

@arttet arttet reopened this Sep 18, 2024
@arttet
Copy link
Contributor Author

arttet commented Sep 18, 2024

Hey @onur-ozkan

I have double-checked the results of CI and haven't found anything related with my changes. Can we please run CI again?

@onur-ozkan
Copy link
Member

Yeah, seems suspicious.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@arttet
Copy link
Contributor Author

arttet commented Sep 19, 2024

Hey @onur-ozkan,

Please note that CI hasn't started yet.

@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2024

📌 Commit ed2e0ab has been approved by onur-ozkan

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 19, 2024

⌛ Testing commit ed2e0ab with merge b0af276...

@bors
Copy link
Contributor

bors commented Sep 19, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing b0af276 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 19, 2024
@bors bors merged commit b0af276 into rust-lang:master Sep 19, 2024
7 of 10 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 19, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b0af276): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.8%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)
4.7% [3.7%, 5.8%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Cycles

Results (secondary 5.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.2% [5.2%, 5.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.752s -> 769.526s (0.10%)
Artifact size: 341.32 MiB -> 341.30 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants