-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-wide: parallel: Fully removed all Lrc
, replaced with Arc
#136471
base: master
Are you sure you want to change the base?
Conversation
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt
cc @davidtwco, @compiler-errors, @TaKO8Ki The Miri subtree was changed cc @rust-lang/miri |
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy
cc @davidtwco, @compiler-errors, @TaKO8Ki Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
I rebased |
tree-wide: parallel: Fully removed all
Lrc
, replaced withArc
This is continuation of #132282 .
I'm pretty sure I did everything right. In particular, I searched all occurrences of
Lrc
in submodules and made sure that they don't need replacement.There are other possibilities, through.
We can define
enum Lrc<T> { Rc(Rc<T>), Arc(Arc<T>) }
. Or we can makeLrc
a union and on every clone we can read from special thread-local variable. Or we can add a generic parameter toLrc
and, yes, this parameter will be everywhere across all codebase.So, if you thing we should take some alternative approach, then don't merge this PR. But if it is decided to stick with
Arc
, then, please, merge.cc "Parallel Rustc Front-end" ( #113349 )
r? SparrowLii
@rustbot label WG-compiler-parallel