cg_llvm: Reduce visibility of some items outside the llvm module
#136721
Conversation
rustbot
added
S-waiting-on-review
dpaoliello
changed the title
| #![expect(dead_code)] | ||
| #![expect(unreachable_pub)] |
There was a problem hiding this comment.
I'm reluctant to do this, even temporarily, because it has the side-effect of disabling dead-code warnings throughout the whole module, even for things that should be warnings (e.g. an unused pub(crate) helper function).
And we would be unable to get rid of it until all of the unwanted warnings are fixed individually.
There was a problem hiding this comment.
hmm. how do nested deny and expect work, exactly?
There was a problem hiding this comment.
IIRC, expect behaves exactly like allow, except that it also emits an unfulfilled_lint_expectations (which is a warning by default) if it doesn't suppress anything.
So if you have warn/deny on an outer module, and then allow/expect on an inner module/item, the diagnostic is suppressed as you would expect.
There was a problem hiding this comment.
If you mean nested in the other direction, I have no idea.
(But I have noticed that if I put #[allow(dead_code)] on an enum, and then #[warn(dead_code)] on one of its variants, there is no diagnostic even if that variant is unused. And if I replace the warn with expect, the expectation is violated.)
There was a problem hiding this comment.
Ok, removed this and re-added the workaround in lib.rs
dpaoliello
force-pushed
the
cleanllvm2
branch
from
00c4ef0 to
5f29273
Compare
Zalathar
changed the title
llvm module
|
Looks good, thanks. @bors r+ rollup |
bors
added
S-waiting-on-bors
cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
Rollup of 11 pull requests Successful merges: - rust-lang#136606 (Fix long lines which rustfmt fails to format) - rust-lang#136663 (Stabilize `NonZero::count_ones`) - rust-lang#136672 (library: doc: core::alloc::Allocator: trivial typo fix) - rust-lang#136704 (Improve examples for file locking) - rust-lang#136721 (cg_llvm: Reduce visibility of some items outside the `llvm` module) - rust-lang#136813 (rustc_target: Add the fp16 target feature for AArch32) - rust-lang#136830 (fix i686-unknown-hurd-gnu x87 footnote) - rust-lang#136832 (Fix platform support table for i686-unknown-uefi) - rust-lang#136835 (Stop using span hack for contracts feature gating) - rust-lang#136837 (Overhaul how contracts are lowered on fn-like bodies) - rust-lang#136839 (fix ensure_monomorphic_enough) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#136721 - dpaoliello:cleanllvm2, r=Zalathar cg_llvm: Reduce visibility of some items outside the `llvm` module Next piece of rust-lang#135502 This reduces the visibility of items (other than those in the `llvm` module) so that dead code analysis will correctly identify unused items.
Next piece of #135502
This reduces the visibility of items (other than those in the
llvmmodule) so that dead code analysis will correctly identify unused items.