Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix: "the a" -> "the" #2503

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Typo fix: "the a" -> "the" #2503

merged 1 commit into from
Oct 16, 2020

Conversation

follower
Copy link
Contributor

@follower follower commented Oct 1, 2020

I think "the release" is preferable to "a release" in this context but I'm no grammarian. :)

@kinnison
Copy link
Contributor

kinnison commented Oct 1, 2020

I'm going to assume you are trying to file PRs for Hacktoberfest.

While this patch is fine intrinsically, I do not wish to encourage this kind of scattergun typo-fix PR approach.

If you want to file some typo fixes for rustup, there's plenty of text to review in the codebase and to suggest corrections for other than this one tiny change. Why not put some effort into that and improve more than a single code comment?

@follower
Copy link
Contributor Author

follower commented Oct 3, 2020

I'm going to assume you are trying to file PRs for Hacktoberfest.

Lol, no, but I suspected that might happen when I saw it hit the news.

In this case I noticed this issue while in the process of writing up a different (still to be submitted) issue.

I mean, I understand the context of the response but still feel like it could've been worded a little more friendly/less presumptively.

@follower
Copy link
Contributor Author

follower commented Oct 3, 2020

(The issue I mentioned writing up being: #2506.)

Anyway, I was also intending to fix the rand typo I'd encountered on the second line here but won't if it's undesired:

// binary. This is intended for cases where historically users
// rand `cargo install rustfmt` and so they had custom `rustfmt`

@rbtcollins
Copy link
Contributor

rbtcollins commented Oct 3, 2020 via email

@kinnison
Copy link
Contributor

I apologise for my tone a couple of weeks ago. But I'm sure you can appreciate the single-typo-fix PR confusion :D

I've since looked at your contributions elsewhere and I have to say that I shouldn't have responded in that fashion.

I assume I put you off other fixes, but I'll merge this anyway. Thank you for your contribution.

@kinnison kinnison merged commit 2b59a3b into rust-lang:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants