Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use indicatif progressbar for downloads #2610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milahu
Copy link

@milahu milahu commented Dec 15, 2020

start solving #1818 #1835 etc

@kinnison said

It'll be quite a bit of work to rearrange all the output to go properly via that, but it would potentially allow some cleanup.

I think that switching to indicatif or another similar library would be an interesting approach. It'd be a significant departure for the current UI if we also funnelled all messaging through such a beast, so we'd need to think carefully.

why refactor all the prints? i just want a download progressbar

code is not tested. github CI, what do you say?

edit: CI says no. also my cargo still says no:

$ cargo update
error: failed to parse manifest at `Cargo.toml`

Caused by:
  feature `profile-overrides` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["profile-overrides"]` to enable this feature

@kinnison
Copy link
Contributor

Are you intending to persue this? if so it'd be sensible to get to the point you can run cargo test --all properly locally before pushing to the CI. Also since progress bars aren't part of our CI since they only appear on terninals, you will have to extensively test locally to be certain nothing has broken.

You can install a locally built rustup with cargo run -- --no-modify-path -y once you're happy with the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants