-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: streamline CI actions to prepare for merge queue introduction #3582
Conversation
4caa051
to
b94646d
Compare
bc923b4
to
9a977c3
Compare
.github/workflows/ci.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated by the script, please ignore it while reviewing.
PS: Actually, it's probably better to ignore .github/workflows/**
changes entirely.
9a977c3
to
a2b18ff
Compare
a2b18ff
to
8c0c075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that makes sense. Thanks for working through this!
@djc Concern: If I'm not mistaken, the conditional The conditional is necessary since we want the workflow to always run to qualify for being used in branch protection. What could've happened? PS: This should not influence the future merge queue integration though, since it depends on a separate |
... I checked the docs again and I don't see why, but probably we should use |
This is one of the prerequisites for closing #3567.
Changes
*-on-*.yaml
intoci.yaml
.all-features
intoci.yaml
.test-docs
intoci.yaml
.freebsd-builds
toci.yaml
.conclusion
toci.yaml
.ci.yaml
is not up to date.