Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusion matrix #374

Merged
merged 12 commits into from
Feb 7, 2025
Merged

Fix confusion matrix #374

merged 12 commits into from
Feb 7, 2025

Conversation

relf
Copy link
Member

@relf relf commented Feb 5, 2025

This PR supersedes PR #249 taking into account review comments

  • Use predicted and ground truth labels to compute confusion matrix
  • Make confusion matrix reproducible by sorting classes (labels). Fixes the order of classification #341.
  • Use sensible default for binary confusion matrix

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (9744625) to head (eed0c49).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/metrics_classification.rs 50.00% 2 Missing ⚠️
src/dataset/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   35.44%   35.49%   +0.04%     
==========================================
  Files          96       96              
  Lines        6371     6379       +8     
==========================================
+ Hits         2258     2264       +6     
- Misses       4113     4115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@relf relf merged commit d910389 into rust-ml:master Feb 7, 2025
22 checks passed
@relf relf deleted the confusion-matrix branch February 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the order of classification
3 participants