Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image dependency to 0.25 #208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update image dependency to 0.25 #208

wants to merge 3 commits into from

Conversation

SolidTux
Copy link

@SolidTux SolidTux commented Jan 3, 2025

This updates the image crate and updates the code for incompatible changes

@MarijnS95 MarijnS95 changed the title Update image crate Update image to 0.25 Jan 3, 2025
MarijnS95
MarijnS95 reviewed Jan 3, 2025
View reviewed changes
xcommon/Cargo.toml Outdated
@@ -10,7 +10,7 @@ license = "Apache-2.0 OR MIT"
anyhow = "1.0.68"
byteorder = "1.4.3"
dunce = "1"
image = { version = "0.24.5", default-features = false, features = ["png", "webp"] }
image = { version = "0.25.5", default-features = false, features = ["png", "webp"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see if 0.25.0 would work equally well :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, it doesn't. But 0.25.2 does.

@MarijnS95 MarijnS95 changed the title Update image to 0.25 Update image dependency to 0.25 Jan 3, 2025
SolidTux and others added 2 commits January 4, 2025 01:07
@SolidTux
Lower image version
a456bfb
@MarijnS95
Reformat imports
e8159e2 
Only imports within the same module share a line.
MarijnS95
MarijnS95 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll accept and merge this for now, but want to have -Zminimal-version CI checking in place before incorporating any other upgrades.

@MarijnS95
Copy link
Member

MarijnS95 commented Jan 6, 2025 •
edited
Loading

Likewise we need to have an MSRV policy. This dependency bumps from 1.61.0 to 1.67.1. I don't know what other MSRV requirements xbuild already has, but we should at the least be explicitly documenting when dependencies are affecting our MSRV, even when bumping it is likely already okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SolidTux @MarijnS95