Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rand to 0.9.0-beta.3; renamed "gen" to "random"; test bigrand; fix test lints #317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bionicles
Copy link

just went through and applied clippy suggestions

@bionicles bionicles changed the title fix clippy lints on tests bump rand to 0.9.0-beta.3; test bigrand module; fix clippy lints on tests Jan 21, 2025
@bionicles
Copy link
Author

i increased the minor version of the rand dependency
renamed "gen" to "random" in bigrand (note: this will be a breaking change, but it's necessary because of the new gen keyword being reserved)
refactored the implementations to match the updated trait
added basic tests for rand feature working (inside bigrand.rs module)

@bionicles bionicles changed the title bump rand to 0.9.0-beta.3; test bigrand module; fix clippy lints on tests bump rand to 0.9.0-beta.3; renamed "gen" to "random"; test bigrand; fix test lints Jan 21, 2025
@cuviper
Copy link
Member

cuviper commented Jan 21, 2025

If you want me to consider the clippy fixes now, please keep that in a distinct PR. Doing too much in one PR is a pretty sure way to make sure none of it gets pulled in -- especially for a first-time contributor.

The rand stuff is a breaking change even if you hadn't changed any names, because that's a public dependency. I also already have my own local branch for this upgrade, but I will wait for the proper rand 0.9.0.

@bionicles
Copy link
Author

ok, not sure how to split up a PR, ill look into it, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants