Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with numerics in
num-traits
is biased towards using the standard traits, which is generally good. However, checked arithmetic is lacking a unifying trait (likeNumOps
). This PR adds that.This trait should theoretically be a supertrait of
PrimInt
. However, this trait (likeNumOps: Rem
), requiresCheckedRem
.PrimInt
does not currently require that, meaning that this would be a breaking change. (PrimInt: CheckedNumOps
for a future release?)