i2c: use PathBuf for socket paths #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
requested review from
stsquad,
vireshk and
stefano-garzarella
as code owners
Ablu
approved these changes
Dec 5, 2023
vireshk
reviewed
Dec 5, 2023
epilys
force-pushed
the
i2c-socket-pathbuf
branch
2 times, most recently
from
ec5426f to
d8709e7
Compare
vireshk
reviewed
Dec 5, 2023
vireshk
reviewed
Dec 5, 2023
epilys
force-pushed
the
i2c-socket-pathbuf
branch
2 times, most recently
from
109146d to
e2576ec
Compare
vireshk
approved these changes
Dec 5, 2023
epilys
force-pushed
the
i2c-socket-pathbuf
branch
from
e2576ec to
2d0e74a
Compare
vireshk
approved these changes
Dec 5, 2023
stefano-garzarella
approved these changes
Dec 5, 2023
clap can parse a PathBuf directly from the command line arguments, and paths are not always UTF-8. Use PathBuf instead of a String to allow for all valid filesystem paths. Signed-off-by: Manos Pitsidianakis <[email protected]>
Check that parent path component exists and is a directory. Signed-off-by: Manos Pitsidianakis <[email protected]>
epilys
force-pushed
the
i2c-socket-pathbuf
branch
from
6f97128 to
187a39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clap can parse a PathBuf directly from the command line arguments, and paths are not always UTF-8. Use PathBuf instead of a String to allow for all valid filesystem paths.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.