Make CPU bound tasks synchronous in Chain
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my original understanding of
asyncruntimes I thought you could slap anasyncon anything you expect to take some time to complete. After further reading, I don't think this is the correct approach for CPU-bound work that does not benefit from concurrency (unless by use of multiple threads but that is besides the point here). The additional context switching of adding a future that may or may not poll as ready might even add some overhead. Here I remove theasyncfrom CPU-bound functions to remove any unnecessary context switching.Happy to let this one marinate for a little if there is some interest in actually profiling if this does anything. Although I don't think there will be any noticeable effect, I think it is good practice to remove the
asyncfrom these functions.ref: https://users.rust-lang.org/t/should-you-only-use-futures-for-i-o-bound-tasks/100784
cc @nyonson