Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report unsoundness in cve-rs, totally-safe-transmute and totally-safe #2221

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Nugine
Copy link
Contributor

@Nugine Nugine commented Feb 10, 2025

We are using cargo audit -D warnings to avoid problematic dependencies.

To prevent anyone from using these crates in the dependency tree (accidentally?), I think it is meaningful to include them in advisories.

Reverse dependencies

resolves #826

@tarcieri
Copy link
Member

See previous discussion on #826

@Nugine
Copy link
Contributor Author

Nugine commented Feb 10, 2025

The three crates are intentional exploits of rustc soundness bugs, like fake-static, which has been flagged in #207 and #270 previously. I personally recommend including them as informational = "unsound".
If RustSec cannot make a decision yet, I'm Ok to leave this PR open and wait.

@kornelski
Copy link
Contributor

These crates may be a joke, but the APIs are unsound for real. I expect cargo audit is used in projects where ending up with any of them as a dependency isn't funny. I would prefer to have them flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

totally-safe-transmute is totally unsafe
3 participants