Add log message filtering #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
running the sample on close of the app i sometimes get: |
extrawurst
requested changes
Nov 12, 2024
|
Please also add a |
|
If the Log Level does not allow us to get anything below |
- Handle closed channel gracefully - Fix formatting
|
Lets use line wrapping: 
|
|
lets use more matching colors with what they use on the terminal: 
|
extrawurst
requested changes
Nov 14, 2024
extrawurst
requested changes
Nov 14, 2024
- Move log_viewer code to its own file - Remove unused pub on ChipMarker - Update log message in simple.rs example to include 1-5 for logs - Update bevy_libgdx_atlas link in README.md - Update log level colors in debug_log_level.rs
|
If I disable showing 
|
extrawurst
requested changes
Nov 18, 2024
CHANGELOG.md
Outdated
| * Added level based log filtering | ||
|
|
||
| ### Removed | ||
| * Stopped creating bevy events for incomming logs |
There was a problem hiding this comment.
i cannot find any code that got removed for this?
There was a problem hiding this comment.
The transfer_log_events function removed here: https://github.com/rustunit/bevy_debug_log/pull/3/files#diff-fb0614459ea1fee2430f5df8e36530289fa54b04e088be756d2db2054c8d7081L33-L43
extrawurst
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.