Added "type found" msg to expose_assert_* fns #3766 #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added `, found ${typeof(n)}` to int, str and bool assertions
* added assertion test for bool
* added positive test for int, str and bool assertions
daxpedda
approved these changes
Jan 16, 2024
aDogCalledSpot
pushed a commit
to aDogCalledSpot/wasm-bindgen
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prints out the type of the argument encountered when the type assertion fails as discussed in #3766
expected a number argumentexpected a number argument, found stringThe core change
, found ${typeof(n)}to int, str and bool assertionsRelated changes
Simple tests did not have anything for boolean type assertion, so I added one because this PR changes the bool assertion and needs a test.
Was it included elsewhere and mine is a duplicate?
Only negative assertions were tested. E.g. passing a string to a number arg.
I added positive tests as well. E.g. passing a number to a number arg.
Maybe there was a reason why they were omitted?