Make getter
/setter
names consistent with js_name
#4273
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix I was talking about in #4270. Please merge #4270, so the effects of this PR become obvious in git diff.
Changes:
getter
andjs_name
,getter
will be chosen. This reflects the old behavior of exported getters. (Also applies tosetter
.)getter
. This is a breaking change, since it potentially changes the import name. (Also applies tosetter
.)This PR resolves TODO 2 from #4230.