-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masking findings feature #70
Conversation
Codecov ReportBase: 66.54% // Head: 67.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 66.54% 67.46% +0.91%
==========================================
Files 18 20 +2
Lines 1665 1758 +93
==========================================
+ Hits 1108 1186 +78
- Misses 557 572 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for opening this pull request! Your contribution is greatly appreciated!
shellclear/src/bin/cmd/clear.rs
Outdated
Shell::Bash, | ||
); | ||
|
||
let args = command().get_matches_from(vec!["clear", "--remove"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, you are trying to test the cli command.
Maybe we can use trycmd
lib for testing the binary itself. It can give us higher coverage and more easy to maintain
shellclear/src/snapshots/shellclear__clearer__tests__remove_sensitive_commands.snap
Show resolved
Hide resolved
shellclear/src/snapshots/shellclear__clearer__tests__persist_sensitive_commands.snap
Show resolved
Hide resolved
# secret_group: 1 | ||
# id: github_env_token | ||
- name: GitHub Env Token | ||
test: GITHUB_TOKEN=([0-9a-zA-Z*_/+]{0,100}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaplanelad should we add _
to all other environment variable regexes?
Closes: #69