Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking findings feature #70

Merged
merged 12 commits into from
Jan 5, 2023
Merged

Conversation

Arnovsky
Copy link
Contributor

Closes: #69

@Arnovsky Arnovsky changed the title Masking text feature Masking findings feature Dec 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Base: 66.54% // Head: 67.46% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (176a752) compared to base (9c9889f).
Patch coverage: 81.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   66.54%   67.46%   +0.91%     
==========================================
  Files          18       20       +2     
  Lines        1665     1758      +93     
==========================================
+ Hits         1108     1186      +78     
- Misses        557      572      +15     
Impacted Files Coverage Δ
shellclear/src/bin/cmd/clear.rs 0.00% <0.00%> (ø)
shellclear/src/bin/cmd/find.rs 0.00% <0.00%> (ø)
shellclear/src/bin/cmd/stash.rs 0.00% <0.00%> (ø)
shellclear/src/bin/shellclear.rs 1.05% <0.00%> (-0.02%) ⬇️
shellclear/src/emoji.rs 0.00% <0.00%> (ø)
shellclear/src/bin/cmd/config.rs 69.69% <85.71%> (ø)
shellclear/src/exporter/data.rs 92.85% <87.50%> (+0.26%) ⬆️
shellclear/src/engine.rs 89.38% <88.09%> (-0.75%) ⬇️
shellclear/src/exporter/table.rs 90.00% <92.30%> (-0.25%) ⬇️
shellclear/src/exporter/text.rs 89.39% <92.30%> (-0.32%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kaplanelad kaplanelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for opening this pull request! Your contribution is greatly appreciated!

Shell::Bash,
);

let args = command().get_matches_from(vec!["clear", "--remove"]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, you are trying to test the cli command.
Maybe we can use trycmd lib for testing the binary itself. It can give us higher coverage and more easy to maintain

# secret_group: 1
# id: github_env_token
- name: GitHub Env Token
test: GITHUB_TOKEN=([0-9a-zA-Z*_/+]{0,100})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaplanelad should we add _ to all other environment variable regexes?

@kaplanelad kaplanelad merged commit 1b58f68 into rusty-ferris-club:main Jan 5, 2023
@Arnovsky Arnovsky deleted the mask-text branch January 8, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request / Idea]: Mask findings
3 participants